adonthell-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Adonthell-commits] [ksterker/adonthell] 10b78d: cmake: added override s

From: GitHub
Subject: [Adonthell-commits] [ksterker/adonthell] 10b78d: cmake: added override setting for compiling swig w...
Date: Fri, 15 Jun 2012 00:38:18 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/ksterker/adonthell
  Commit: 10b78df45a7ac36c5e0f25e9fd0835316eabd50f
      
https://github.com/ksterker/adonthell/commit/10b78df45a7ac36c5e0f25e9fd0835316eabd50f
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/py-runtime/CMakeLists.txt
    M src/py-wrappers/adonthell/CMakeLists.txt

  Log Message:
  -----------
  cmake: added override setting for compiling swig wrapper code

SWIG wrapper code has so many useless warnings in it, that it causes
us to turn off -Werror during compiles, just to get a finished product.

Another product's bugs shouldn't encourage bugs in our own code.

This commit adds the flag: ADDITIONAL_SWIG_CXXFLAGS, which can be
set on the cmake command line, which will be added to all python
code.  This catches the py-runtime directory, and the py-wrappers
directory.  Unfortunately, it also catches py-wrappers/py_main.cc, which
is our code as well, but that is only one file.

To enable -Wall -Werror while skipping SWIG errors, use:

cmake \
        -DCMAKE_C_FLAGS:STRING="-Wall -Werror" \
        -DCMAKE_CXX_FLAGS:STRING="-Wall -Werror" \
        -DADDITIONAL_SWIG_CXXFLAGS:STRING="-Wno-error" \
        ..

The -Wno-error is added after the usual flags, allowing the compile to
succeed for the SWIG wrapper code.


  Commit: 0bd8a8594a10aad0fd3c758586421c4a17c83a0b
      
https://github.com/ksterker/adonthell/commit/0bd8a8594a10aad0fd3c758586421c4a17c83a0b
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/gfx/png_wrapper.cc
    M src/rpg/pathfinding_costs.cc
    M src/world/pathfinding.cc
    M test/guitest.cc

  Log Message:
  -----------
  Removed unused variables, fixing compiler warnings


  Commit: 00d1889283d1e927028c2e0aa7e4908809e8aa1b
      
https://github.com/ksterker/adonthell/commit/00d1889283d1e927028c2e0aa7e4908809e8aa1b
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/gfx/surface.cc
    M src/gui/label.cpp
    M src/gui/layout.cc
    M src/gui/textbox.cpp
    M src/world/area.cc
    M src/world/mapview.cc
    M src/world/renderer.cc

  Log Message:
  -----------
  Fixed more signed/unsigned comparison warnings


  Commit: dbfa57dc41fbaf73ca71df53f6601aad9d7d0906
      
https://github.com/ksterker/adonthell/commit/dbfa57dc41fbaf73ca71df53f6601aad9d7d0906
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/gfx/sprite.cc

  Log Message:
  -----------
  Fixed lack of return in non-void function


  Commit: 7fd2086f4ea6f0a3d37f4ecceda4744e92ed5be4
      
https://github.com/ksterker/adonthell/commit/7fd2086f4ea6f0a3d37f4ecceda4744e92ed5be4
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/gui/window_manager.cc

  Log Message:
  -----------
  Fixed warning about missing options in switch stmt

Not sure if additional cases should be added, so just added a couple
defaults.


  Commit: 2b3672cfd8d48107d865eed5fe6423d7a7d43280
      
https://github.com/ksterker/adonthell/commit/2b3672cfd8d48107d865eed5fe6423d7a7d43280
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/world/placeable.cc

  Log Message:
  -----------
  Fixed constructor initialization order warning


  Commit: 318c7c79b6daebfb81a8cc565ce132f1f49cbfe0
      
https://github.com/ksterker/adonthell/commit/318c7c79b6daebfb81a8cc565ce132f1f49cbfe0
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/world/placeable.cc
    M src/world/renderer.cc

  Log Message:
  -----------
  Fixed std namespace typo, and whitespace


  Commit: 81384c157a0ae608dd7967d4b52d47cab10f32f8
      
https://github.com/ksterker/adonthell/commit/81384c157a0ae608dd7967d4b52d47cab10f32f8
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M test/inputtest.cc

  Log Message:
  -----------
  test: added another missing return statement in non-void function


  Commit: b11a7f148855c7743e937e56b242221ccda947b1
      
https://github.com/ksterker/adonthell/commit/b11a7f148855c7743e937e56b242221ccda947b1
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/world/renderer.cc

  Log Message:
  -----------
  Fixed lack of return in non-void function

The is...below() function appears to me to be complete, and so
I did not presume to return true or false in the final case.
Instead I added an exception.  This may impact performance slightly,
and may need to be removed, and given a real true/false, if
all tests above fail.


  Commit: beb986331cef14955357d4c45af5886603739f41
      
https://github.com/ksterker/adonthell/commit/beb986331cef14955357d4c45af5886603739f41
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/world/test_placeable.cc

  Log Message:
  -----------
  Added random hash string to test_placeable.cc constructor


  Commit: 1db75c6c96aa43f111de8ef7df68c1cef65ad8fb
      
https://github.com/ksterker/adonthell/commit/1db75c6c96aa43f111de8ef7df68c1cef65ad8fb
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/world/area.cc
    M src/world/area_manager.cc

  Log Message:
  -----------
  world: fixed forgetful filename in area::load()

We probably always want to remember the filename in load(), even if
we are not successful, so that in the case we wish to save, we still can.

Without the filename, the save fails by attempting to write to the
directory/ name.


  Commit: 623bd4fa6385cf410600049dbbf5bc15e6f10684
      
https://github.com/ksterker/adonthell/commit/623bd4fa6385cf410600049dbbf5bc15e6f10684
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/rpg/character.cc
    M src/rpg/character.h

  Log Message:
  -----------
  rpg::character: added new static cleanup()

Moved the commented out code from ::load() into the new ::cleanup()
API, and fixed the cleanup loop as well.


  Commit: 69677a26a4073cda31b2689f73d4df1f666c0ec3
      
https://github.com/ksterker/adonthell/commit/69677a26a4073cda31b2689f73d4df1f666c0ec3
  Author: Chris Frey <address@hidden>
  Date:   2012-06-11 (Mon, 11 Jun 2012)

  Changed paths:
    M src/base/serializer.h
    M src/event/date.cc
    M src/event/date.h
    M test/callbacktest.cc

  Log Message:
  -----------
  serializer: added static cleanup() API call, and supporting implementations


  Commit: a626e3e9375c1ae64fbdcc95490f219c77bdec92
      
https://github.com/ksterker/adonthell/commit/a626e3e9375c1ae64fbdcc95490f219c77bdec92
  Author: Chris Frey <address@hidden>
  Date:   2012-06-12 (Tue, 12 Jun 2012)

  Changed paths:
    M src/base/savegame.cc
    M src/rpg/group.h
    M src/rpg/specie.cc
    M src/rpg/specie.h
    M test/data/groups/group.py
    M test/data/groups/human.specie
    A test/data/specie.data
    M test/worldtest.cc

  Log Message:
  -----------
  Added savegame/serializer support to rpg::specie

This commit adds support for savegame and serializer support to the
code base, and adds the new serializer to worldtest.

It also fixes the cleanup() API assumptions, removing the specie
constructor code that added 'this' to its own static Species vector.
The load() function is now responsible for filling Species, and cleanup()
is responsible for freeing.

Fixed missing constructor initialization also.

Added new test/data/specie.data, which, for now, contains the same data
as test/data/groups/human.specie.

Also adds new import to test/data/groups/group.py, so rpg is visible to SWIG.


  Commit: ea0b44efacd052b49aa1d69e95e435b1696986a1
      
https://github.com/ksterker/adonthell/commit/ea0b44efacd052b49aa1d69e95e435b1696986a1
  Author: Chris Frey <address@hidden>
  Date:   2012-06-12 (Tue, 12 Jun 2012)

  Changed paths:
    M test/worldtest.cc

  Log Message:
  -----------
  Removed the hardcoded human.specie load from test/worldtest.cc


Compare: 
https://github.com/ksterker/adonthell/compare/4b6c073ed822...ea0b44efacd0
reply via email to
[Prev in Thread] Current Thread [Next in Thread]