[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: usage of ac_check_header
From: |
Joao Miguel Ferreira |
Subject: |
Re: usage of ac_check_header |
Date: |
Tue, 24 Jul 2007 11:00:48 +0100 |
On Tue, 2007-07-24 at 00:25 +0200, Ralf Wildenhues wrote:
> Hello Joao,
>
Hi Ralph,
> a small side point regarding M4 quotation: instead of
>
> * Joao Miguel Ferreira wrote on Mon, Jul 23, 2007 at 10:18:08PM CEST:
> > AC_CHECK_HEADER(xpath.h,,AC_MSG_ERROR([cannot find headers for libxml2]))
>
> it's better to write this:
>
> AC_CHECK_HEADER(xpath.h,,[AC_MSG_ERROR([cannot find headers for libxml2])])
>
Is this something I could/should do globally ???
for example, I also have these:
- AC_CHECK_HEADERS(unistd.h sys/socket.h)
- AC_CHECK_FUNCS(socket htons)
- AC_CHECK_LIB(xml2,xmlParseDoc,,AC_MSG_ERROR([cannot link to libxml2]))
could/should I quote it all ? I'm quite used to quoting in Perl... is
this somewhat similar ?
jmf
> (quoting the first argument of AC_CHECK_HEADER would be prudent, too).
>
> It was very painful before the last Autoconf release to fix AC_MSG_ERROR
> to not rely on this (it cannot because there is loads of old macro code
> that has this underquotation, but that doesn't mean we shouldn't advise
> against it for new code).
>
> Cheers,
> Ralf