[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: autotest: problem testing daemons, with possible fix
From: |
Luke Mewburn |
Subject: |
Re: autotest: problem testing daemons, with possible fix |
Date: |
Fri, 26 Nov 2010 10:24:56 +1100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, Nov 25, 2010 at 10:47:08AM -0800, Paul Eggert wrote:
| On 11/23/2010 08:58 PM, Luke Mewburn wrote:
| > Is there any reason that AT_CHECK doesn't close this fd before
| > executing the application?
|
| Thanks for reporting the problem.
|
| I don't know of any reason AT_CHECK wouldn't do that, but I'm
| not intimately familiar with the code. Perhaps Paolo (who contributed
| this code back in 2003) can comment.
|
| > I've attached a patch that performs this, against autoconf-2.68.
|
| That patch doesn't smell right to me. The output is being redirected
| for a reason, and simply undoing the redirection feels odd. I
| suspect that any fix should be done inside AT_CHECK instead. Could
| you try the following instead, and see whether it works for you? I'm
| not sure it's right (hadn't had time to analyze this code) but I think
| it's an improvement.
Your patch also solves the problem.
thanks,
Luke.
pgpQEHf50sxWT.pgp
Description: PGP signature