[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [avrdude-dev] [patch #7703] AT89S5x support, stk500 spi frequency bu
From: |
Jan Waclawek |
Subject: |
Re: [avrdude-dev] [patch #7703] AT89S5x support, stk500 spi frequency bugfix, other minor fixes |
Date: |
Mon, 16 Jan 2012 23:01:03 +0100 |
Joerg,
>I'm happy with about everything you are telling, except one:
>
>> I tend to set my editor to strip extra spaces from line
>> ends and convert tabs to spaces; sorry.
>
>There's one general rule:
>
>Don't mess with other people's style.
... I wouldn't deliberately do that, exactly because ...
> Style changes easily
>obfuscate actual code changes in the version history, and
>thus make it hard to track down bugs later on.
If you look into those patches, you'll find that most of the "style" changes
are removed trailing spaces. Actually, I discovered that only after I run the
svn diff. Honestly, I can't quite understand why would any programmer set the
editor to preserve trailing spaces; and as they hardly constitute an item of
"style", removing them certainly does not alter the stylistic appearance of the
files. The resulting patchfile is a mess, I admit, and please feel free to
remove these superfluous automatic edits - I simply don't know how to do it
without extensive manual work, as I don't use revision systems of this kind nor
the patch/diff system regularly. If that helps, I can post the complete working
directory to some convenient place.
The tabs are chaged for spaces only in the lines I edited (although there may
be lines which I edited and then restored, so they now differ only in the
tabs/spaces). That probably won't pose a problem as I that does not alter the
style - I believe I can guess what was the original tab setting - besides...
> AVRDUDE's files, unfortunately, don't follow a consistent
>style at all)
.. so doing that I did not really divert from the existing practice... :-)
Jan