[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Ayttm-devel] Function prototypes in .c files
From: |
Andy |
Subject: |
[Ayttm-devel] Function prototypes in .c files |
Date: |
Tue, 21 Jan 2003 01:34:50 -0100 |
User-agent: |
KMail/1.4.3 |
I noticed in Philip's latest changes to sound.c, he replaced #include "util.h"
and #include "dialog.h" with the protoypes for the functions used in
sound.c:
int clean_pid(void * dummy); /* util.h */
void do_error_dialog(char *message, char *title); /* dialog.h */
I don't think this is a very good idea. The prototype is in the header for a
reason and we should be including the header file. There should be one
declaration and one definition of a function. Not doing this means that
there are N declarations floating around which can be a headache to maintain.
Comments?
Andy
- [Ayttm-devel] Function prototypes in .c files,
Andy <=