bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] normalization tweaks for macOS


From: Grisha Levit
Subject: Re: [PATCH] normalization tweaks for macOS
Date: Tue, 25 Jul 2023 16:06:58 -0400

On Mon, Jul 24, 2023 at 10:12 AM Chet Ramey <chet.ramey@case.edu> wrote:
>
> On 7/20/23 7:52 PM, Grisha Levit wrote:
>
> > I wonder if you'd be interested in changes
> > to the function that would skip escaping ASCII characters that aren't
> > glob-special as well.  I _think_ it would just be a slight variation
> > of the code that already does this for regexes but I haven't thought
> > about the edge cases carefully yet.
>
> I agree that it would only be a slight variation on that code, and so I
> added that case. It will be in the next devel branch push.

Re latest changes in [1], we need to preserve quoting also for any of
the following characters, at least if they are in a bracket
expression:
! - . : = ^

Attached patch does so but is probably more complicated than necessary.

Also, there's a mention of changes to complete.def in the changelog
but it looks like the actual changes didn't make it into the commit.

[1]: 
https://git.savannah.gnu.org/cgit/bash.git/diff/pathexp.c?h=devel&id=8418224f3

Attachment: 0001-preserve-quoting-for-chars-special-in-bracket-expr.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]