[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 2.7: Warnings in yacc.c
From: |
Akim Demaille |
Subject: |
Re: 2.7: Warnings in yacc.c |
Date: |
Mon, 8 Apr 2013 12:05:45 +0200 |
Le 3 avr. 2013 à 17:32, Akim Demaille <address@hidden> a écrit :
>> lalr1.cc generates warning 4065 in a couple of places that have only a
>> default case in the switch
I have handled some of these as follows. Some are not
covered, and I will not address them in 2.7.1, but
maybe in a future release.
commit 3cf3393bd419f907902034272d6a4b930c62b542
Author: Akim Demaille <address@hidden>
Date: Mon Apr 8 11:13:22 2013 +0200
skeletons: avoid empty switch constructs
Reported by Rob Conde.
http://lists.gnu.org/archive/html/bug-bison/2013-03/msg00003.html
* data/c.m4 (b4_symbol_actions): Rename as...
(_b4_symbol_actions): this.
(b4_symbol_actions): New wrapper.
Do not emit empty switches.
Adjust all b4_symbol_actions callers.
diff --git a/data/c.m4 b/data/c.m4
index a1dc2c5..bcafe42 100644
--- a/data/c.m4
+++ b/data/c.m4
@@ -440,15 +440,15 @@ m4_define([b4_case],
$2
break;])
-# b4_symbol_actions(FILENAME, LINENO,
-# SYMBOL-TAG, SYMBOL-NUM,
-# SYMBOL-ACTION, SYMBOL-TYPENAME)
-# -------------------------------------------------
+# _b4_symbol_actions(FILENAME, LINENO,
+# SYMBOL-TAG, SYMBOL-NUM,
+# SYMBOL-ACTION, SYMBOL-TYPENAME)
+# --------------------------------------------------
# Issue the code for a symbol action (e.g., %printer).
#
# Define b4_dollar_dollar([TYPE-NAME]), and b4_at_dollar, which are
# invoked where $<TYPE-NAME>$ and @$ were specified by the user.
-m4_define([b4_symbol_actions],
+m4_define([_b4_symbol_actions],
[b4_dollar_pushdef([(*yyvaluep)], [$6], [(*yylocationp)])dnl
case $4: /* $3 */
b4_syncline([$2], [$1])
@@ -458,6 +458,20 @@ b4_syncline(address@hidden@], address@hidden@])
b4_dollar_popdef[]dnl
])
+# b4_symbol_actions(KIND)
+# -----------------------
+# Emit the symbol actions for KIND ("printers" or "destructors").
+# Dispatch on "yytype".
+m4_define([b4_symbol_actions],
+[m4_ifval(m4_defn([b4_symbol_$1]),
+[[switch (yytype)
+ {
+]m4_map([_b4_symbol_actions], m4_defn([b4_symbol_$1]))[
+ default:
+ break;
+ }]],
+[YYUSE (yytype);])])
+
# b4_yydestruct_generate(FUNCTION-DECLARATOR)
# -------------------------------------------
@@ -487,12 +501,7 @@ b4_parse_param_use[]dnl
yymsg = "Deleting";
YY_SYMBOL_PRINT (yymsg, yytype, yyvaluep, yylocationp);
- switch (yytype)
- {
-]m4_map([b4_symbol_actions], m4_defn([b4_symbol_destructors]))[
- default:
- break;
- }
+ ]b4_symbol_actions([destructors])[
}]dnl
])
@@ -530,12 +539,7 @@ b4_parse_param_use[]dnl
# else
YYUSE (yyoutput);
# endif
- switch (yytype)
- {
-]m4_map([b4_symbol_actions], m4_defn([b4_symbol_printers]))dnl
-[ default:
- break;
- }
+ ]b4_symbol_actions([printers])[
}
diff --git a/data/glr.cc b/data/glr.cc
index 49b4fa1..73d0f28 100644
--- a/data/glr.cc
+++ b/data/glr.cc
@@ -167,12 +167,7 @@ m4_pushdef([b4_parse_param],
m4_defn([b4_parse_param_orig]))dnl
std::ostream& yyoutput = debug_stream ();
std::ostream& yyo = yyoutput;
YYUSE (yyo);
- switch (yytype)
- {
- ]m4_map([b4_symbol_actions], m4_defn([b4_symbol_printers]))dnl
-[ default:
- break;
- }
+ ]b4_symbol_actions([printers])[
}
diff --git a/data/lalr1.cc b/data/lalr1.cc
index 68de8b4..750c3a4 100644
--- a/data/lalr1.cc
+++ b/data/lalr1.cc
@@ -422,12 +422,7 @@ do { \
std::ostream& yyo = debug_stream ();
std::ostream& yyoutput = yyo;
YYUSE (yyoutput);
- switch (yytype)
- {
- ]m4_map([b4_symbol_actions], m4_defn([b4_symbol_printers]))dnl
-[ default:
- break;
- }
+ ]b4_symbol_actions([printers])[
}
@@ -454,12 +449,7 @@ do { \
if (yymsg)
YY_SYMBOL_PRINT (yymsg, yytype, yyvaluep, yylocationp);
- switch (yytype)
- {
- ]m4_map([b4_symbol_actions], m4_defn([b4_symbol_destructors]))[
- default:
- break;
- }
+ ]b4_symbol_actions([destructors])[
}
void