Re: change of socketport constructor

[Federico Montesino Pouzols]

        Yes, I think the patch is ready to be applied, and it solves
an important issue that has been pending for a long time. I would
apply it immediately, but since the patch implies many functional
changes, I think we should wait to see if there are people already
using the old code and if this change could break and make it
difficult to update some applications.

        Anyway, I personally think the patch should be applied, and if
there are applications using the old version of SocketService, they
should be better updated to use the new version. Opinions?

On Fri, Apr 18, 2003 at 06:32:18PM +0200, klaus triendl wrote:
> now, here is the patch (against the commoncpp2-1.0.9 release, hope this is
> ok);
> apply it in the root of commoncpp2 with ``patch -p1 < ccgnu2.diff"; only
> ``include/cc++/socket.h" and ``src/port.cpp" are patched;
> 
> 
> what it does:
> 
> change ``SocketPort::SocketPort()" not to accept a service anymore;
> change ``void SocketPort::expired()" in ``bool SocketPort::expired()";
> don't proceed with ``retry:" and don't put the port into the event array if
> expired() returns true
> SocketService::~SocketService iterates the socketports itself and sets
> SocketPort::service = NULL before deleting SocketPort in order to prevent
> updating the SocketService
> change SocketService::detach() not to update the service
> SocketPort::setTimer()+incTimer() don't update the service anymore
> adds SocketPort::detach() to be able to detach from the SocketService in
> e.g. expired() (i need this because the data processing is threaded because
> it could take a long time, so it is possible that the socket expires and is
> closed before the data processing finishes)


> _______________________________________________
> Bug-commoncpp mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-commoncpp