Re: ddd/MString.h problems in 3.3 with Solaris C++ compiler, liberty install problems

[Andreas Zeller]

Hi!

Arnaud Desitter <arnaud@nag.co.uk> writes:

> Hi,
> 
> Please try:
> 
> > >         _mstring(text ? XmStringCreateLtoR((char *)text, (char*)charset) 
> > > : 0)
> instead of:
> > >         _mstring(text ? XmStringCreateLtoR((char *)text, charset) : 0)
> 
> That should help.

I'm not sure about this: the Sun CC message explicitly stated that the
`text' parameter was erroneous.  

Also, this change would have to be applied to the next N constructors
as well (which didn't report any problems).

Finally, it risks to introduce new errors on systems where
`XmStringCharSet' is not defined as a `char *' or `const char *'.


> Note that it would be better to use "const_cast<char*>".

I'd love to.  But so far, DDD's C++ code still more or less compiles
with very old C++ compilers (which, among others, do not support
`const_cast'...)

-- 
Andreas Zeller     Universitaet Passau
                   http://www.fmi.uni-passau.de/st/staff/zeller/