Re: data display cannot be left-to-right at startup

[Andreas Zeller]

Hi!

Wen-Liang Lee <wllee@avanticorp.com> writes:

> I set data placement "left to right" under Preferences->data and
> SAVE it.  However, the next time I run ddd, it still uses "top to
> bottom" style.  If I open Preferences->data, the toggle button does
> show "left to right".  I have to click "top to bottom" and then
> click back to "left to right" and press OK. From now on, it uses
> "left to right" style.

Thanks!  This is a bug in DDD.  Please try the included patch; it will
also be in the next DDD release.

Andreas

cvs server: Diffing ddd
Index: ddd/ddd.C
===================================================================
RCS file: /cvsroot/ddd/ddd/ddd/ddd.C,v
retrieving revision 1.618
diff -u -r1.618 ddd.C
--- ddd/ddd.C   2001/02/12 06:16:48     1.618
+++ ddd/ddd.C   2001/02/23 10:25:50
@@ -4046,6 +4046,18 @@
        // data_disp->refresh_display();
     }
 
+    // Synchronize layout direction with placement
+    switch (app_data.display_placement)
+    {
+    case XmVERTICAL:
+       XtVaSetValues(data_disp->graph_edit, XtNrotation, 0, NULL);
+       break;
+           
+    case XmHORIZONTAL:
+       XtVaSetValues(data_disp->graph_edit, XtNrotation, 90, NULL);
+       break;
+    }
+
     if (app_data.command_toolbar && 
        command_toolbar_w != 0 && !XtIsManaged(command_toolbar_w))
     {
Index: ddd/options.C
===================================================================
RCS file: /cvsroot/ddd/ddd/ddd/options.C,v
retrieving revision 1.173
diff -u -r1.173 options.C
--- ddd/options.C       2001/01/26 09:24:09     1.173
+++ ddd/options.C       2001/02/23 10:25:52
@@ -523,22 +523,14 @@
        unsigned char orientation = (unsigned char)(int)(long)client_data;
        app_data.display_placement = orientation;
 
-       Arg args[10];
-       Cardinal arg = 0;
-
-       // Synchronize layout direction with placement
-       switch (orientation)
+       switch (app_data.display_placement)
        {
        case XmVERTICAL:
-           XtSetArg(args[arg], (char *)XtNrotation, 0); arg++;
-           XtSetValues(data_disp->graph_edit, args, arg);
            set_status("New displays will be placed "
                       "below the downmost display.");
            break;
            
        case XmHORIZONTAL:
-           XtSetArg(args[arg], (char *)XtNrotation, 90); arg++;
-           XtSetValues(data_disp->graph_edit, args, arg);
            set_status("New displays will be placed on the "
                       "right of the rightmost display.");
            break;


-- 
Andreas Zeller     Universitaet Passau
                   http://www.fmi.uni-passau.de/st/staff/zeller/