[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-diffutils] Re: [patch] i18n patch for diffutils
From: |
Jim Meyering |
Subject: |
[bug-diffutils] Re: [patch] i18n patch for diffutils |
Date: |
Thu, 25 Feb 2010 18:02:15 +0100 |
Matthew Burgess wrote:
> Linux From Scratch is currently carrying the attached patch that we
> took verbatim from Redhat some time ago. It apparently fixes an issue
> concerning handling whitespace in multibyte locales, but comes with no
> test case so I'm unable to figure out whether this has been fixed in
> some other way already. I note there was some discussion at
> http://lists.gnu.org/archive/html/bug-gnu-utils/2008-01/msg00030.html
> regarding side-by-side comparisons in multibyte locales, but can't
> tell whether the fixes there may have fixed up whatever this patch is
> trying to do.
>
> Apologies for such a wishy-washy report; I'm hoping someone with more
> knowledge of the source code and multibyte issues may be able to
> figure out quicker than I can whether the patch LFS is currently
> carrying is still required, and whether it can be applied as-is
> upstream.
Thanks for taking the time.
Normally I'd be very interested.
However, in this case, the patch ends up duplicating
a lot of important logic, and I'm holding out hope
that we'll end up with multibyte support that avoids
that maintenance pitfall while still retaining most of
the single-byte performance.
If you do find a test case that demonstrates how that patch
can help (or any test case), I'd be happy to add that, independent
of adding the code to fix it.