|
From: | Eric Blake |
Subject: | Re: [bug-diffutils] bug: diff -r swaps the files it should check |
Date: | Mon, 08 Aug 2011 11:04:07 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.11 |
On 08/08/2011 09:54 AM, Paul Eggert wrote:
On 08/08/2011 08:44 AM, Eric Blake wrote:once you update to the latest gnulib, you may want to remove this redundant line:I don't see that as a redundancy. Diffutils accesses the file system directly, as well as via gnulib. If gnulib were to change such that it didn't need to access the file system (admittedly unlikely), then gnulib could drop the dependency; but diffutils would still need it.
Then diffutils should explicitly include 'largefile' in its list of required modules, as in:
diff --git i/bootstrap.conf w/bootstrap.conf index 5aa783b..e6a76b4 100644 --- i/bootstrap.conf +++ w/bootstrap.conf @@ -46,6 +46,7 @@ gnupload hard-locale inttostr inttypes +largefile maintainer-makefile manywarnings mbrtowcI still argue that it is wrong to duplicate AC_SYS_LARGEFILE if we are explicitly depending on a gnulib module documented to guarantee that same aspect.
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |