[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-diffutils] [PATCH] tests: use more portable fd redirection in T
From: |
Jim Meyering |
Subject: |
Re: [bug-diffutils] [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT |
Date: |
Wed, 12 Oct 2011 19:46:48 +0200 |
Stefano Lattarini wrote:
> You might also want to apply the attached follow-up, with prevents
> an unportable usage of fd redirections in TESTS_ENVIRONMENT.
>
...
> Subject: [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT
>
> * tests/Makefile.am (TESTS_ENVIRONMENT): Redirection with `exec 9>&2'
> is not portable to various Korn shells, and to (at least) HP-UX 11
> /bin/sh. Use a more portable idiom.
> See http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/22488 for
> lots of discussion.
> ---
> tests/Makefile.am | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 9835ab6..9952d67 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -21,7 +21,6 @@ EXTRA_DIST = \
> TESTS_ENVIRONMENT = \
> tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.; \
> TMPDIR=$$tmp__; export TMPDIR; \
> - exec 9>&2; \
> export \
> VERSION='$(VERSION)' \
> abs_top_builddir='$(abs_top_builddir)' \
> @@ -40,7 +39,7 @@ TESTS_ENVIRONMENT = \
> PREFERABLY_POSIX_SHELL='$(PREFERABLY_POSIX_SHELL)' \
> REPLACE_GETCWD=$(REPLACE_GETCWD) \
> PATH='$(abs_top_builddir)/src$(PATH_SEPARATOR)'"$$PATH" \
> - ;
> + ; 9>&2
>
> LOG_COMPILER= $(SHELL)
Thank you.
Applied.