[bug-diffutils] bug#63670: CI failure due to warning in diff.c

[Paul Eggert]

On 2023-05-23 09:46, Bruno Haible wrote:

> The diffutils CI reports a build failure:
>
>
>    CC       diff.o
> ../../../sources/diffutils/src/diff.c: In function 'compare_files':
> ../../../sources/diffutils/src/diff.c:1209:8: error: missing initializer for 
> field 'name' of 'struct file_data' [-Werror=missing-field-initializers]

I don't know how to find out the details of the diffutils CI build. 
However, I think the bug is probably that the build was using GCC 11.1 
or 11.2, which is buggy in this area. I installed the attached patches 
to Gnulib to work around that problem.

If you're configuring with --enable-gcc-warnings or equivalent, it's 
better to use current GCC. Older versions of GCC have several problems 
in this area, and although I went to the trouble of working around this 
particular problem I doubt whether it's worth our time to worry about 
all false positives generated by older GCC versions, so  it might be 
better to build with --disable-gcc-warnings on older platforms.

0001-manywarnings-port-better-to-GCC-11.2-and-earlier.patch
Description: Text Data

0002-Simplify-Wno-missing-field-initializers-checking.patch
Description: Text Data

0003-manywarnings-speed-up-nomfi-test.patch
Description: Text Data