Re: [bug-gawk] array methods belong in a struct, not an array

[Andrew J. Schorr]

Hi,

On Sun, Jan 06, 2019 at 05:30:16AM -0700, address@hidden wrote:
> "Andrew J. Schorr" <address@hidden> wrote:
> 
> > I propose the attached patch that removes the alength function and cleans
> > up this issue.
> 
> This is OK, but is not quite complete. There are, I think, two uses
> in symbol.c and one in gawkapi.c where direct access to xxx->table_size
> should be replaced by assoc_empty.  Please fix those as well and then
> push to master.

I pushed it to master. Note that it does not include the array type
resetting patch. Do you want that one in master or in stable?

> > But taking another step back, I'm not sure why these array methods are
> > implemented as an array of function pointers instead of as a struct
> > with a field for each method.
> 
> This would be a step forward.  If you can work up a patch for that for
> review, I'd appreciate it.

Attached.

Regards,
Andy

array.patch
Description: Text document