[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] Glade/GtkBuilder related bugs
From: |
Daiki Ueno |
Subject: |
Re: [bug-gettext] Glade/GtkBuilder related bugs |
Date: |
Thu, 31 Jan 2013 12:20:10 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Miguel Ángel <address@hidden> writes:
>> Do we really need to extract "context" attribute from every element?
>> Otherwise, I guess it can be folded in the while-loop below to extract
>> the translator comments.
>>
> My second patch points this, but that is not the issue. Actually there
> is a problem, I pointed it out at the next mail of my pile in
> bug-gettext archive ;-).
Could you link to the mails (also bugs)? That would be helpful to
understand the context which we are talking about. There is a web
archive: https://lists.gnu.org/archive/html/bug-gettext/
> Glade2 and GtkBuilder are not compatible. The
> first one have in the context attribute "yes" or "no" and the string
> have the Glib syntax "msgctxt|msgid". The second one has msgctxt in the
> context attribute.
Ah, ok. Thanks for the explanation.
> I have already a functional xgettext with GtkBuilder support and Glade
> fixed, but the implementation is not a simple patch. The new tests are
> almost copied from existing xgettext-* tests, but filled with new data,
> and I have extended xgettext-glade-4 also. You can see it at
> https://github.com/644rosen/gettext_gtkbuilder_support.git
I've briefly looked at the "glade_bugs" branch and it looks basically
good. One thing is, isn't it possible for x-glade.c to utilize arglist
parser instead of adding a new function 'split_glib_syntax_string'?
Also please separate out unrelated changes, like:
https://github.com/644rosen/gettext_gtkbuilder_support/commit/f766f238
I think this commit can be merged regardless of glade/gtkbuilder
support. Thanks for triaging the bugs anyway!
Regards,
--
Daiki Ueno