Re: Bug fix

[Andreas Jaeger]

toulouse <address@hidden> writes:

> Hello,
> 
> I'm using the linux pthreads library included in glibc-2.2.2, and i
> discovered a bug inside timer_getoverrun function. The last function
> call inside timer_getoverrun must be pthread_mutex_unlock and not
> pthread_mutex_lock (line 42). Could tell me when the timer functions
> will be integrated in the standard glibc library?

Thanks, if this patch goes in today, it will be in glibc 2.2.3.

Uli, ok to commit?

Andreas

2001-04-24  Andreas Jaeger  <address@hidden>

        * sysdeps/pthread/timer_getoverr.c (timer_getoverrun): Unlock the
        mutex instead of double locking it.
        Reported by Pierre Artaud <address@hidden>.

Index: linuxthreads/sysdeps/pthread/timer_getoverr.c
===================================================================
RCS file: /cvs/glibc/libc/linuxthreads/sysdeps/pthread/timer_getoverr.c,v
retrieving revision 1.3
diff -u -r1.3 timer_getoverr.c
--- timer_getoverr.c    2000/06/20 00:33:55     1.3
+++ timer_getoverr.c    2001/04/24 12:03:03
@@ -1,4 +1,4 @@
-/* Copyright (C) 2000 Free Software Foundation, Inc.
+/* Copyright (C) 2000, 2001 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Kaz Kylheku <address@hidden>.
 
@@ -39,7 +39,7 @@
   else
     retval = 0; /* TODO: overrun counting not supported */
 
-  pthread_mutex_lock (&__timer_mutex);
+  pthread_mutex_unlock (&__timer_mutex);
 
   return retval;
 }

-- 
 Andreas Jaeger
  SuSE Labs address@hidden
   private address@hidden
    http://www.suse.de/~aj