Re: 2.2.4, gsed != sed

[Andreas Jaeger]

Toomas Rosin <address@hidden> writes:

> Hello!
>
> If gsed != sed, then build fails in the "intl" subdirectory (duplicate
> label 'b' in po2test.sed:53).  `configure' checks for gsed, but the
> result is not used anywhere.
>
> Fix (against the 2.2.4 release):
>
> --- config.make.in.~1~        Mon Jul 23 19:53:35 2001
> +++ config.make.in    Sat Dec 22 22:37:04 2001
> @@ -83,6 +83,7 @@
>  MIG = @MIG@
>  PWD_P = @PWD_P@
>  BISON = @BISON@
> +SED = @SED@
>  
>  # Installation tools.
>  INSTALL = @INSTALL@
> --- intl/Makefile.~1~ Mon Dec 17 02:56:49 2001
> +++ intl/Makefile     Mon Dec 17 02:59:13 2001
> @@ -77,7 +77,7 @@
>  
>  $(objpfx)msgs.h: po2test.sed ../po/de.po
>       $(make-target-directory)
> -     sed -f $^ > $@
> +     $(SED) -f $^ > $@
>  
>  CFLAGS-tst-gettext.c = -DTESTSTRS_H=\"$(objpfx)msgs.h\"
>  CFLAGS-tst-gettext2.c = -DOBJPFX=\"$(objpfx)\"

There're more places that could need SED both in Makefiles and shell scripts.

The patch is fine and I'd like to commit it together with a replace of
sed with $(SED) in all Makefiles.  Uli, what do you think?

I'm not sure what to do with the shell scripts.  Should we ignore
those for now?

Andreas
-- 
 Andreas Jaeger
  SuSE Labs address@hidden
   private address@hidden
    http://www.suse.de/~aj