bug-glibc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: common install-sh?


From: Akim Demaille
Subject: Re: common install-sh?
Date: 27 Sep 2002 08:56:07 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)

| Not that it's a huge deal, but I noticed that the install-sh script
| distributed with automake (including 1.7) was different from the
| install-sh in gettext/automake, which was different from the install-sh
| in gnulib.

The master copy recenly moved from Autoconf to Automake.

| The gnulib version quotes more of the filename variables, hopefully
| enough so that filenames with whitespace actually work (I did not
| exhaustively test). 

This patch is funny: it removes some useless quotes, but adds some new
useless quotes.  Such as here:

| ***************
| *** 55,62 ****
|   dir_arg=""
|   
|   while [ x"$1" != x ]; do
| !     case "$1" in
| !     -c) instcmd=$cpprog
|           shift
|           continue;;
|   
| --- 55,62 ----
|   dir_arg=""
|   
|   while [ x"$1" != x ]; do
| !     case $1 in
| !     -c) instcmd="$cpprog"
|           shift
|           continue;;
|   

There is never word splitting in assignments, so that's really useless.

| Also, Jim wrote a second way to do the removal before the install, I
| gather to handle being able to install the `rm' binary itself.
| 
| The diffs below also send all the fatal errors to stderr instead of
| stdout.
| 
| These diffs are relative to the automake version.  The glibc/gettext
| version seems to be older, at least I didn't see any conflicting changes.
| 
| If these look ok, maybe you'd incorporate them into the other distributions,
| and we can have one version again ...

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]