[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33736: flymake test different-diagnostic-types confuses gcc and CC
From: |
João Távora |
Subject: |
bug#33736: flymake test different-diagnostic-types confuses gcc and CC |
Date: |
Fri, 04 Jan 2019 20:21:48 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Glenn Morris <rgm@gnu.org> writes:
> Glenn Morris wrote:
>
>> flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
>> However, what matters to the rest of the test is $CC, not gcc.
>
> AFAICS the tests are gcc-specific, so the Makefile should enforce that:
>
> --- i/test/lisp/progmodes/flymake-resources/Makefile
> +++ w/test/lisp/progmodes/flymake-resources/Makefile
> @@ -8,6 +8,6 @@ CC_OPTS = -Wall -Wextra
> ## normally use flymake, so it seems like just avoiding the issue
> ## in this test is fine. Set flymake-log-level to 3 to investigate.
> check-syntax:
> - GCC_COLORS= $(CC) $(CC_OPTS) ${CHK_SOURCES} || true
> + GCC_COLORS= gcc $(CC_OPTS) ${CHK_SOURCES} || true
>
> # eof
Makes sense, thanks.
João
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#33736: flymake test different-diagnostic-types confuses gcc and CC,
João Távora <=