[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33870: 27.0.50; xref-goto-xref not configurable
From: |
Juri Linkov |
Subject: |
bug#33870: 27.0.50; xref-goto-xref not configurable |
Date: |
Sun, 06 Jan 2019 01:27:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
Here's a better patch that relies on display-buffer-in-previous-window:
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 87ce2299c5..169f49a348 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -482,19 +482,9 @@ xref--show-pos-in-buf
(window-live-p xref--original-window)
(or (not (window-dedicated-p xref--original-window))
(eq (window-buffer xref--original-window) buf)))
- `(,(lambda (buf _alist)
- (set-window-buffer xref--original-window buf)
- xref--original-window))))))
- (with-selected-window
- (with-selected-window
- ;; Just before `display-buffer', place ourselves in the
- ;; original window to suggest preserving it. Of course, if
- ;; user has deleted the original window, all bets are off,
- ;; just use the selected one.
- (or (and (window-live-p xref--original-window)
- xref--original-window)
- (selected-window))
- (display-buffer buf action))
+ `((display-buffer-in-previous-window)
+ (previous-window . ,xref--original-window))))))
+ (with-selected-window (display-buffer buf action)
(xref--goto-char pos)
(run-hooks 'xref-after-jump-hook)
(let ((buf (current-buffer)))
- bug#33870: 27.0.50; xref-goto-xref not configurable, (continued)
bug#33870: 27.0.50; xref-goto-xref not configurable, Dmitry Gutov, 2019/01/03
bug#33870: 27.0.50; xref-goto-xref not configurable, Dmitry Gutov, 2019/01/03
bug#33870: 27.0.50; xref-goto-xref not configurable,
Juri Linkov <=
bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2019/01/07
bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2019/01/07
bug#33870: 27.0.50; xref-goto-xref not configurable, martin rudalics, 2019/01/08
bug#33870: 27.0.50; xref-goto-xref not configurable, João Távora, 2019/01/08
bug#33870: 27.0.50; xref-goto-xref not configurable, martin rudalics, 2019/01/08