[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
From: |
Alex Branham |
Subject: |
bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el |
Date: |
Fri, 15 Feb 2019 07:26:36 -0600 |
User-agent: |
mu4e 1.1.0; emacs 27.0.50 |
On Fri 15 Feb 2019 at 02:46, Eli Zaretskii <eliz@gnu.org> wrote:
>> Either way, the attached patch should be OK I think.
>
> Thanks. As a further nit, please mention the bug number in the log
> message when you know it (as you usually do when posting a second
> version of the patches). Otherwise I need to add that manually with
> "git commit --amend".
I'm not sure why this is so hard for me to remember, sorry. Will try
harder in the future (including the attached patch!).
> Here's the diagnostics from the failed test; can you spot the problem?
Have you changed `conf-assignment-column'? That would cause issues I
guess. Here's a patch that sets it in the test:
From bbc00e4f70425618f5a6ed59a00afe1d1fcf9427 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 15 Feb 2019 07:17:49 -0600
Subject: [PATCH] Fix a conf-mode test
* test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments):
Set `conf-assignment-column'.
Bug#34419
---
test/lisp/textmodes/conf-mode-tests.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/lisp/textmodes/conf-mode-tests.el
b/test/lisp/textmodes/conf-mode-tests.el
index 5d79ceec96..effe8de397 100644
--- a/test/lisp/textmodes/conf-mode-tests.el
+++ b/test/lisp/textmodes/conf-mode-tests.el
@@ -29,11 +29,12 @@
(ert-deftest conf-test-align-assignments ()
"Test for `conf-align-assignments'."
(with-temp-buffer
- (insert "foo: bar\nbar: baz")
- (conf-colon-mode)
- (conf-align-assignments)
- (should (equal (buffer-string)
- "foo: bar\nbar:
baz"))))
+ (let ((conf-assignment-column 24))
+ (insert "foo: bar\nbar: baz")
+ (conf-colon-mode)
+ (conf-align-assignments)
+ (should (equal (buffer-string)
+ "foo: bar\nbar:
baz")))))
(ert-deftest conf-test-font-lock ()
(with-temp-buffer
--
2.19.2
From bbc00e4f70425618f5a6ed59a00afe1d1fcf9427 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Fri, 15 Feb 2019 07:17:49 -0600
Subject: [PATCH] Fix a conf-mode test
* test/lisp/textmodes/conf-mode-tests.el (conf-test-align-assignments):
Set `conf-assignment-column'.
Bug#34419
---
test/lisp/textmodes/conf-mode-tests.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/test/lisp/textmodes/conf-mode-tests.el
b/test/lisp/textmodes/conf-mode-tests.el
index 5d79ceec96..effe8de397 100644
--- a/test/lisp/textmodes/conf-mode-tests.el
+++ b/test/lisp/textmodes/conf-mode-tests.el
@@ -29,11 +29,12 @@
(ert-deftest conf-test-align-assignments ()
"Test for `conf-align-assignments'."
(with-temp-buffer
- (insert "foo: bar\nbar: baz")
- (conf-colon-mode)
- (conf-align-assignments)
- (should (equal (buffer-string)
- "foo: bar\nbar:
baz"))))
+ (let ((conf-assignment-column 24))
+ (insert "foo: bar\nbar: baz")
+ (conf-colon-mode)
+ (conf-align-assignments)
+ (should (equal (buffer-string)
+ "foo: bar\nbar:
baz")))))
(ert-deftest conf-test-font-lock ()
(with-temp-buffer
--
2.19.2
signature.asc
Description: PGP signature
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Alex Branham, 2019/02/10
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Eli Zaretskii, 2019/02/11
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Alex Branham, 2019/02/11
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Eli Zaretskii, 2019/02/15
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el,
Alex Branham <=
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Eli Zaretskii, 2019/02/15
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Alex Branham, 2019/02/18
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Eli Zaretskii, 2019/02/18
- bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el, Alex Branham, 2019/02/19