[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34215: 27.0.50; Provide elisp access to Chinese pinyin-to-character
From: |
Eric Abrahamsen |
Subject: |
bug#34215: 27.0.50; Provide elisp access to Chinese pinyin-to-character mapping |
Date: |
Sat, 23 Feb 2019 21:36:10 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
On 02/01/19 11:48 AM, Eli Zaretskii wrote:
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Date: Thu, 31 Jan 2019 11:35:32 -0800
>>
>> +(defun pinyin-convert ()
>> + "Convert text file pinyin.map into an elisp library.
>> +The library is named pinyin.el, and contains the constant
>> +`pinyin-character-map'."
>> + (let ((src-file (car command-line-args-left))
>> + (dst-file (cadr command-line-args-left))
>> + (coding-system-for-write 'utf-8-emacs))
>
> This should be 'utf-8-unix. There's no reason to write out stuff in
> our internal encoding, as the file is not supposed to have any
> characters not representable in UTF-8.
>
> Otherwise, this LGTM. Let's wait for a few days for more comments,
> and then push.
Doesn't look like anything more is forthcoming, shall I push to master?