[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35018: 26.1; Use diff as en ert-explainer for string=
From: |
Pierre Neidhardt |
Subject: |
bug#35018: 26.1; Use diff as en ert-explainer for string= |
Date: |
Tue, 02 Apr 2019 09:59:59 +0200 |
Thanks for the review!
Noam Postavsky <npostavs@gmail.com> writes:
>> (defun webfeeder--string=-explainer (string-a string-b)
>> "Return the diff output of STRING-A and STRING-B"
>> (unless (string= string-a string-b)
>
> I guess a diff won't help so much for single line strings, so maybe the
> condition should check for that? e.g.
>
> (or (string= string-a string-b)
> (not (string-match-p "\n" string-a))
> (not (string-match-p "\n" string-b))
Yes, this is very nice!
>> (let (file-a file-b)
>> (unwind-protect
>> (let (result)
>> (setq file-a (make-temp-file "webfeeder")
>> file-b (make-temp-file "webfeeder"))
>> (with-temp-file file-a
>> (insert string-a))
>> (with-temp-file file-b
>> (insert string-b))
>> (setq result
>> (with-temp-buffer
>> ;; The following generates a *Diff* buffer which is
>> ;; convenient for coloration.
>> (diff file-a file-b nil 'no-async)
>> (diff-no-select file-a file-b nil 'no-async
>> (current-buffer))
>
> Isn't the diff-no-select redudant, since diff already calls it?
The first diff is a typo. It should be diff-no-select only.
Cheers!
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature