[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34915: 27.0.50; Wdired regression with ls -F
From: |
Basil L. Contovounesios |
Subject: |
bug#34915: 27.0.50; Wdired regression with ls -F |
Date: |
Fri, 26 Apr 2019 17:20:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
tags 34915 fixed
close 34915
quit
Stephen Berman <stephen.berman@gmx.net> writes:
> On Fri, 26 Apr 2019 14:56:57 +0100 "Basil L. Contovounesios"
> <contovob@tcd.ie> wrote:
>
>> Thanks. I noticed an opportunity for a tiny bit of reuse:
> [...]
>
> I'm not sure the two uses justify a new function, but I don't oppose
> it.
I'll leave it for now.
>> Which makes me wonder: is there no Dired function that
>> wdired--restore-dired-filename-prop can reuse for finding the boundaries
>> of a file name? Is dired-move-to-end-of-filename not suitable? It
>> seems to perform similar checks for symlinks and --classify.
>
> dired-move-to-end-of-filename doesn't work in wdired-mode because the
> dired-filename text property it uses was removed to fix bug#32173, and
> wdired--restore-dired-filename-prop was added to compensate. I couldn't
> come up with a more elegant solution.
Thanks for explaining and for working on this. Since your patch fixed
the bug, I'm closing this report.
--
Basil