|
From: | Dmitry Gutov |
Subject: | bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance |
Date: | Thu, 5 Jan 2023 15:01:17 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
I'd like to let our language-level specialists to take the deeper look.Do we have any reason to believe that the performance of `buffer-match-p` is a problem in `display-buffer-alist`? The benchmark you quote seems to be fairly different from what `display-buffer` does. I'm not surprised your optimization improves this benchmark, but I'm wondering whether this use-case corresponds to a real life situation (and if so which).
I was also wondering that.
On the last note, I'm curious how many buffers would it take to see a 50ms improvement in match-buffers' runtime when using the current project-kill-buffer-conditions's value, for example.Also, where is `match-buffers` used? I only see it used in `lisp/net/rcirc.el` in a way that can trivially be replaced with something much more efficient.
I suppose it could replace the use of dolist+project--buffer-check inside project--buffers-to-kill. But the main target of the patch under discussion is buffer-match-p, of course.
[Prev in Thread] | Current Thread | [Next in Thread] |