[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for
From: |
Theodor Thornhill |
Subject: |
bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions |
Date: |
Sun, 05 Feb 2023 22:20:19 +0100 |
Theodor Thornhill <theo@thornhill.no> writes:
> Theodor Thornhill <theo@thornhill.no> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> Cc: "61142@debbugs.gnu.org" <61142@debbugs.gnu.org>
>>>> Date: Sun, 05 Feb 2023 20:19:19 +0100
>>>> From: Theodor Thornhill via "Bug reports for GNU Emacs,
>>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>>
>>>> +(defvar c-ts-common-nestable-if-statement-p t
>>>> + "Does the current parser nest if-else statements?
>>>> +
>>>> +T if the current tree-sitter grammar nests the else if
>>>> +statements, NIL otherwise.")
>>>
>>> A nit: we use t and nil, lowercase, to refer to these two symbols.
>>>
>>> Thanks.
>>
>> Thanks!
>>
>> Theo
>
> I added some small tweaks, and will add the following as a test later:
>
I made even further tweaks, and while testing the c variant I noticed
that the C tests weren't actually working. There were missing rules for
many of the cases in the tests, so I added some more rules to the
c-ts-mode indentation and added a big-ish test with some wonky but
seemingly working indentation.
Because the tests are now working I think this is good to go, so unless
somebody objects I'll install this sometime tomorrow :-)
Theo
0001-Use-c-ts-common-statement-offset-in-java-ts-mode-bug.patch
Description: Text Data
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, (continued)
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, 赵 纪阳, 2023/02/06
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Eli Zaretskii, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/05
- bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions,
Theodor Thornhill <=
- bug#61142: 回复: bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, 赵 纪阳, 2023/02/06
- bug#61142: 回复: bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions, Theodor Thornhill, 2023/02/06