[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-funct
From: |
Felician Nemeth |
Subject: |
bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function |
Date: |
Tue, 14 Feb 2023 16:56:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Theo,
> The LSP spec supports an optional command in the completion results, so
> that the server can know what completion candidate was selected. That
> information can then be used by the server to score candidates for
> better completion results etc.
Can you list some servers that send this info? And if it is not too
much trouble can write a simple recipe where supporting this feature
actually makes a difference? Thanks.
> This simple patch adds support for this.
> I have no strong opinions on _where_ exactly the command should be sent,
> as in before or after the didchange notification.
The specification only says: "An optional command that is executed
*after* inserting this completion." I think it is worth asking for
clarification at https://github.com/microsoft/language-server-protocol
(I'd guess it's safer to send the command after the didChange
notification.)
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Theodor Thornhill, 2023/02/14
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function,
Felician Nemeth <=
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Theodor Thornhill, 2023/02/14
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, João Távora, 2023/02/14
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Theodor Thornhill, 2023/02/15
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Theodor Thornhill, 2023/02/18
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, João Távora, 2023/02/18
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Theodor Thornhill, 2023/02/20
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Felician Nemeth, 2023/02/15
- bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function, Theodor Thornhill, 2023/02/15