Jim Porter <jporterbugs@gmail.com> writes:
I just see one issue with the patch: the NEWS entry and docstring are a bit
misleading. I know these are just copying from the existing Eshell functions,
but this isn't really accurate: "Use Emacs grep facility instead of calling
external rgrep." It *always* calls the external rgrep; it's just that sometimes
the output goes into a compilation buffer.
I don't think that's always the case. In the "eshell-grep" function it
checks if external grep is available, and if not then it uses a slow
elisp-only implementation. Then it checks to see if the output is being
redirected, and so on.
IMO that entire process constitutes the "emacs grep facility" as
described in the docstring.