bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#59943: 30.0.50; ERC 5.5+: Add visual indicator to ERC keep-place


From: J.P.
Subject: bug#59943: 30.0.50; ERC 5.5+: Add visual indicator to ERC keep-place
Date: Tue, 02 Jan 2024 06:47:39 -0800
User-agent: Gnus/5.13 (Gnus v5.13)

>From emacs -Q

  1. M-: (setopt erc-keep-place-indicator-follow t) RET
     M-x erc RET ... RET

  2. In the server buffer, do M-x erc-keep-place-indicator-mode RET

  3. Scroll "up" to hide the indicator but not so far that point moves
     beyond `erc-insert-marker'

  4. Switch away to another buffer and then back

  5. Notice the indicator fails to update

This happens because `keep-place-indicator' is a local module, and it
adds `erc--keep-place-indicator-on-window-buffer-change' to the hook
`window-buffer-change-functions' locally. But that function needs to run
in the buffer that's being switched to, which may not have the mode
enabled (and thus not have the hook member available). Subscribing to
the hook globally should fix the problem. There are also at least two
bugs affecting the integration between `keep-place-indicator' and
`keep-place'. The attached patch attempts to address these as well.

Attachment: 0001-5.6-Make-erc-send-input-lines-a-normal-function.patch
Description: Text Data

Attachment: 0002-5.6-Use-global-window-hook-for-erc-keep-place-indica.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]