[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#68570: 29.1; recompile might not re-use project-compile's buffer
From: |
Juri Linkov |
Subject: |
bug#68570: 29.1; recompile might not re-use project-compile's buffer |
Date: |
Wed, 24 Jan 2024 19:11:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) |
>>>> Recompiling from a non-compilation buffer has security concerns.
>>>> The patch that I proposed above is intended only for
>>>> recompiling from a compilation buffer. It sets
>>>> `compilation-buffer-name-function' in the compilation buffer.
>>> I think it behaves correctly inside the compilation buffer already? At
>>> least it did when I tested.
>> Sorry, I didn't show my compilation function:
>> (setopt project-compilation-buffer-name-function
>> (lambda (name-of-mode)
>> (generate-new-buffer-name
>> (project-prefixed-buffer-name name-of-mode))))
>> Currently 'g' doesn't create a new compilation buffer, because
>> 'compilation--default-buffer-name' just reuses the current buffer.
>
> Is that bad?
It's very useful to always create a unique buffer for every compilation:
this allows keeping error messages from previous compilations.
I propose even to add such an option to the choice list in
project-compilation-buffer-name-function, e.g.:
(defcustom project-compilation-buffer-name-function nil
:type '(choice (const :tag "Default" nil)
(const :tag "Prefixed with project name"
project-prefixed-buffer-name)
(const :tag "Prefixed and unique with project name"
project-prefixed-unique-buffer-name)
(function :tag "Custom function")))
The previous patch would be needed as well since currently
there is no way to allow unique project compilation buffers.
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, (continued)
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/21
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Juri Linkov, 2024/01/22
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Jörg Bornemann, 2024/01/22
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/22
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Juri Linkov, 2024/01/23
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/23
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Jörg Bornemann, 2024/01/23
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/23
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Juri Linkov, 2024/01/24
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/24
- bug#68570: 29.1; recompile might not re-use project-compile's buffer,
Juri Linkov <=
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/25
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Juri Linkov, 2024/01/27
- bug#68570: 29.1; recompile might not re-use project-compile's buffer, Dmitry Gutov, 2024/01/28
bug#68570: 29.1; recompile might not re-use project-compile's buffer, Jörg Bornemann, 2024/01/22