[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#69952: [PATCH] Support pdumping compiled queries by dumping their so
From: |
Eli Zaretskii |
Subject: |
bug#69952: [PATCH] Support pdumping compiled queries by dumping their source |
Date: |
Mon, 22 Apr 2024 09:18:49 +0300 |
> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 21 Apr 2024 23:04:47 -0700
> Cc: Daniel Colascione <dancol@dancol.org>,
> serg.foo@gmail.com,
> 69952@debbugs.gnu.org
>
> >> No. You need both tree-sitter library and the grammar library.
> >
> > That's what I thought. So starting Emacs in that case will attempt to
> > call a function from the tree-sitter library, and will segfault,
> > right? If so, we should have some protection in the code in
> > pdumper.c that loads queries, which tests that tree-sitter is
> > availabale, and if not does something to prevent the segfault, like
> > not loading the query, perhaps?
>
> Right, it can use Ftreesit_available_p (we can define a C equivalent if
> pdumper can’t call lisp), and decide whether to compile the query or just
> keep the query as a string, or signal an error?
We cannot safely signal an error at that point, I think, so just
keeping the query as a string should do, as it will then signal an
error at run time when that query is used, is that right?
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Eli Zaretskii, 2024/04/13
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Yuan Fu, 2024/04/20
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Eli Zaretskii, 2024/04/20
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Yuan Fu, 2024/04/20
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Eli Zaretskii, 2024/04/21
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Yuan Fu, 2024/04/21
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Eli Zaretskii, 2024/04/22
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Yuan Fu, 2024/04/22
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source,
Eli Zaretskii <=
- bug#69952: [PATCH] Support pdumping compiled queries by dumping their source, Yuan Fu, 2024/04/22