bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#70653: [PATCH] Support source line location for Python ExceptionGrou


From: kobarity
Subject: bug#70653: [PATCH] Support source line location for Python ExceptionGroup
Date: Tue, 30 Apr 2024 16:27:30 +0900
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Eli Zaretskii wrote:
> 
> > From: ". shynur" <one.last.kiss@outlook.com>
> > Date: Mon, 29 Apr 2024 16:24:10 +0000
> > msip_labels: 
> > 
> > (This patch is written for Inferior Python mode.)
> > 
> > The original behavior considered only the case of
> > single exception:
> > 
> > ```
> > Traceback (most recent call last):
> >   File "<string>", line 17, in __PYTHON_EL_eval
> >   File "c:/Users/shynur/Desktop/Python/a.py", line 1, in <module>
> >     raise Exception
> > Exception
> > ```
> > 
> > In the above example, one can click at the 3rd line to jump
> > to the corresponding source line.  This patch adds support
> > for the following case (i.e., the built-in ExceptionGroup):
> > 
> > ```
> > + Exception Group Traceback (most recent call last):
> >   |   File "<string>", line 17, in __PYTHON_EL_eval
> >   |   File "c:/Users/shynur/Desktop/Python/a.py", line 1, in <module>
> >   |     raise ExceptionGroup("", [Exception()])
> >   | ExceptionGroup:  (1 sub-exception)
> >   +-+---------------- 1 ----------------
> >     | Exception
> >     +------------------------------------
> > ```
> 
> Adding kobarity to the discussion.

It looks good to me.  Is it better to write NEWS since it is a change
of the customize variable?

Maybe we should also add ExceptionGroup as a Python keyword.  The
patch is attached.  Should I open a new bug?

Attachment: 0001-Add-ExceptionGroup-as-a-Python-keyword.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]