[Bug-gnu-radius] Overflow with Big Acct-Output-Octets values

[Philipp Kolmann]

Hi,

we just started a VPN service based on a LINUX pptp server and a RADIUS
Accounting server.

Everything works nice, but today I noticed twice that I got negatice
Acct-Output-Octets values in the MySQL DB. First I thought it might be a MySQL
bug and made a bigger field for the values.

But the second time I investigated it, and found something which looks like a
bug in the RADIUSd.

bash-2.03# ./radiusd -v
radiusd: GNU Radius version 0.96.3 (sparc-sun-solaris2.8)
Compilation platform: sun 
Debugging flags: 
Compilation flags: PWD_SHADOW USE_SQL_MYSQL 
Ports in use:
 AUTH: 1645
 ACCT: 1646
Paths:
 configuration directory: /opt/GNUradius/etc/raddb
 logging directory:       /usr/adm
 accounting directory:    /usr/adm/radacct
 pidfile:                 /opt/GNUradius/etc/raddb/radiusd.pid

When the pppd stops, it exits with these values into the logfile:

Sep 24 17:36:54 moria pppd[26010]: Modem hangup
Sep 24 17:36:54 moria pppd[26010]: Connection terminated.
Sep 24 17:36:54 moria pppd[26010]: Connect time 259.8 minutes.
Sep 24 17:36:54 moria pppd[26010]: Sent 2392168396 bytes, received 58313082
bytes.
Sep 24 17:36:54 moria pppd[26010]: Connect time 259.8 minutes.
Sep 24 17:36:54 moria pppd[26010]: Sent 2392168396 bytes, received 58313082
bytes.
Sep 24 17:36:54 moria pppd[26010]: Exit.


Looks good so far:
The I get into the accounting debug log:

Tue Sep 24 17:36:54 2002
        Acct-Session-Id = 3D9049B7659A
        User-Name = address@hidden
        Acct-Status-Type = Stop
        Service-Type = Framed-User
        Framed-Protocol = PPP
        Acct-Authentic = RADIUS
        Acct-Session-Time = 15585
        Acct-Output-Octets = 2392168396
        Acct-Input-Octets = 58313082
        Acct-Output-Packets = 1843489
        Acct-Input-Packets = 1344037
        NAS-Port-Type = Async
        Framed-IP-Address = 193.170.72.33
        NAS-IP-Address = 193.170.72.7
        NAS-Port-Id = 2
        Acct-Delay-Time = 0
        Timestamp = 1032881814
        Request-Authenticator = Verified


But the the SQL statement has a corrupted value (taken from the mysql.log
file):
                 360188 Query       UPDATE calls SET status=2,
acct_session_time=15585,acct_input_octets=58313082,
acct_output_octets=-1902798900,
connect_term_reason=0,logout_time='2002-09-24 17:36:54' WHERE
user_name='address@hidden' AND status = 1 AND 
acct_session_id='3D9049B7659A'

Here you can see, that the statement has the wrong value in it.

I didn't find any statement about this in the Changelog file for 0.96.4 but I
will compile the new package tonight.

Hope you can help me,

Thanks
Kind regards
Philipp Kolmann

-- 
To err is human;
to really screw things up requires the root password.