[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD
From: |
Bruno Haible |
Subject: |
Re: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD |
Date: |
Sun, 06 Jan 2019 22:36:36 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) |
Eric Blake wrote:
> I've now applied the patches, with tweaks as discussed on 1/2.
In GNU gettext, I now see this message when using the top-level GNUmakefile:
/bin/bash: rsyncable: command not found
The reason is that GNU gettext imports the relevant files directly (via
'gnulib-tool --copy-file'), ignoring the module description. This is a
reasonable thing to do, since GNU gettext does not ship GNUmakefile nor
maint.mk in the tarballs; it uses them only in the git checkouts.
This patch fixes it for me.
2019-01-06 Bruno Haible <address@hidden>
maintainer-makefile: Make the configure.ac section optional.
* top/maint.mk (GREP, SED): Define if not defined.
diff --git a/top/maint.mk b/top/maint.mk
index 4b57410..4e37efe 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -21,6 +21,12 @@
# ME := $(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
ME := maint.mk
+# These variables ought to be defined through the configure.ac section
+# of the module description. But some packages import this file directly,
+# ignoring the module description.
+GREP ?= grep
+SED ?= sed
+
# Helper variables.
_empty =
_sp = $(_empty) $(_empty)