bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NSUser.m: Bug on Windows handling spaces in environement variable values


From: Roland Schwingel
Subject: NSUser.m: Bug on Windows handling spaces in environement variable values?
Date: Mon, 02 Feb 2004 14:14:56 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007

Hi...

Maybe there is a bug in NSUser.m.
In CVS revision 1.75 there was a changed added to not permit spaces in $USERPROFILE. Why was it added? This really leads to a problem in countries like germany where this will defenitly will contain spaces (default starts with C:\Dokumente und Einstellungen). We disabled this test
a few weeks ago here and till now we found no problems with it.

IMHO this test can (and should) be removed... This is done by applying the attached patch.

Thanks,

Roland



--- NSUser.m.orig       2004-01-21 13:49:11.000000000 +0100
+++ NSUser.m    2004-01-21 13:49:48.000000000 +0100
@@ -260,7 +260,7 @@
             for the user on more modern versions of windoze. */
          s = GSStringFromWin32EnvironmentVariable("USERPROFILE");
        }
-      if (s != nil)
+      /*if (s != nil)
        {
          const char    *str = [s cString];
 
@@ -273,7 +273,7 @@
                }
              str++;
            }
-       }
+       }*/
       [gnustep_global_lock unlock];
     }
   if ([s length] == 0 && [loginName length] != 1)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]