Re: bug and fix for gnustep-base

[Fred Kiefer]

Hi Carl,


Thank you for this bug report. This is already fixed in the main branch, we 
just need to have a new release to publish that change. Could you please try to 
clone this version and verify that the issue is resolved?

Cheers,
Fred


On the road

> Am 22.10.2023 um 07:17 schrieb Carl Hansen <carlhansen@gnu.org>:
> 
> I am disinclined to register at Microsoft github, so I post the bug here.
> 
> 
> the situation:
> 
> compiling gnustep-base 1.29.0  with the latest libxml2 which is 2.11.5
> 
> 
> the problem:
> 
> 
> GSXML.m: In function 'getEntityDefault':
> GSXML.m:2674:22: error: 'xmlEntity' {aka 'struct _xmlEntity'} has no member 
> named 'checked'
> 2674 |               if (ret->checked == 0)
>      |                      ^~
> GSXML.m:2676:22: error: 'xmlEntity' {aka 'struct _xmlEntity'} has no member 
> named 'checked'
> 2676 |                   ret->checked = 1;
>      |                      ^~
> 
> the reason:
>      Like it says, "no member named 'checked'"
> 
>      Here is the relevant change in libxml2 :
>      
> https://gitlab.gnome.org/GNOME/libxml2/-/commit/ce76ebfd1312459951d555ad9d87fb9a89eede55
> 
> 
> 
> the patch:
> 
> 
> diff -x config.log -x config.status -ru 
> tmp/gnustep-base-1.29.0/Source/Additions/GSXML.m 
> work/gnustep-base-1.29.0/Source/Additions/GSXML.m
> --- tmp/gnustep-base-1.29.0/Source/Additions/GSXML.m    2023-01-08 
> 00:41:32.000000000 -0800
> +++ work/gnustep-base-1.29.0/Source/Additions/GSXML.m    2023-10-21 
> 13:51:29.989588310 -0700
> @@ -2671,10 +2671,12 @@
>                   return NULL;
>                 }
>               ret->owner = 1;
> -              if (ret->checked == 0)
> +              /* non-existent field
> +            if (ret->checked == 0)
>                 {
>                   ret->checked = 1;
>                 }
> +           ****    */
>             }
>         }
>     }
> 
> 
> 
>