Re: could not build 2.0.0.12 on Slackware 12.1/x86

[Claudio Fontana]

On Thu, Jun 26, 2008 at 9:32 PM, Yavor Doganov <address@hidden> wrote:
> On Thu, Jun 26, 2008 at 08:50:22PM +0200, Claudio Fontana wrote:
>> ouch.. Do I really need gnome-vfs? I have a firefox
>> 2.0.0.14 installation that does not seem to require it.
>
> Right.  IceCat should not require GNOME.
>
>> If I need gnome-vfs then nevermind, I guess that would require
>> other gnome dependencies.
>
> This is an entirely correct assumption; most probably my conclusion is
> wrong.  Sorry about that; please ignore it.
>
> Can you try with 2.0.13?  I can't build 2.0.12 on a gNewSense system
> either, so it might be a quirk that is fixed in 2.0.13.
>
> I can't immediately see what's wrong from the files you posted, but I'm
> not familiar with IceCat's build system.  Maybe others might give some
> clues.

I managed to get it to build. Here is what I did:

since the error complained about MayOpenPopup not being defined
in libgklayout.a, I looked at the relevant Makefile, and saw only a
SHARED_LIBRARY_LIBS target. Since in the icecat binary the
non-shared lib is used, I tried defining a LIB variable with the
value of SHARED_LIBRARY_LIBS again, and seemed to do the
trick.

Maybe someone with more understanding can do the right fix.
Here is the p0 diff that WFM:

--- layout/build/Makefile~      2008-06-26 17:07:47.000000000 +0200
+++ layout/build/Makefile       2008-06-26 23:52:06.000000000 +0200
@@ -201,6 +201,8 @@
 endif
 endif

+LIBS=$(SHARED_LIBRARY_LIBS)
+
 EXTRA_DSO_LDOPTS = \
                $(LIBS_DIR) \
                $(EXTRA_DSO_LIBS) \