[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] distcheck: ensure dist-hook fails if syntax-check fails
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] distcheck: ensure dist-hook fails if syntax-check fails |
Date: |
Sun, 16 Oct 2011 10:37:07 +0200 |
User-agent: |
KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) |
Hi Jim.
On Friday 14 October 2011, Jim Meyering wrote:
> Stefano Lattarini wrote:
> > * Makefile.am (run-syntax-check): Fix logic, to ensure that
> > the recipe of this target returns a non-zero exit status if
> > "make syntax-check" fails.
>
> Good catch. Applied.
>
Thanks. But now that I think about it, I see that we could improve
the rule even more, by making it work in VPATH builds too; i.e., from:
$(AM_V_GEN)test ! -d .git || $(MAKE) syntax-check
to:
$(AM_V_GEN)test ! -d $(top_srcdir)/.git || $(MAKE) syntax-check
Of course, this makes sense only if the syntax checks themselves work
in VPATH builds ...
Regards,
Stefano