bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #59604] [ms] IP indents using wrong type size after GROWPS-ed headi


From: G. Branden Robinson
Subject: [bug #59604] [ms] IP indents using wrong type size after GROWPS-ed heading
Date: Fri, 11 Jun 2021 01:35:54 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Update of bug #59604 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #6:


commit 6a505946b5036f2b149d3a3e5c86f5ceb9f1c3fc
Author: Tadziu Hoffmann <hoffmann@usm.uni-muenchen.de>
Date:   Sat Aug 18 04:23:00 2018 +1000

    [ms]: Fix Savannah #59604.
    
    Indent an IP paragraph based on the type size of the paragraph text, not
    a preceding heading.  We have to delay evaluating IP's argument until
    the font size has been reset, which I've attempted to do by simply
    passing the argument unevaluated down the call hierarchy, instead of
    saving it in a number register right away, as appears customary in this
    ms implementation.
    
    However, par@reset is called from a great number of places, and these
    usually set the indent registers beforehand.  I've left this as it is,
    so now two ways of setting the indents exist: via register and
    optionally via argument.
    
    * tmac/s.tmac (par@reset): Move font-size setting stuff before
      indent-setting stuff; set registers from optional arguments with
      default "n" scaling indicator before setting indents.
    
      (par*start, par@finish): Don't set registers, but instead pass
      arguments to par@reset.
    
      (@IP): Pass argument unevaluated to par*start.
    
    [Thanks to T. Kurt Bond for updating the patch and championing the
    resolution of this bug!  --GBR]

commit a109785fc41243a9f38cdbaa33b6e420b776e372
Author: Tadziu Hoffmann <hoffmann@usm.uni-muenchen.de>
Date:   Sat Aug 18 04:23:00 2018 +1000

    tmac/s.tmac: Use "u" scaling indicator more.
    
    * tmac/s.tmac (@QP, @XP): Be more scrupulous about using "u" scaling
      indicator.

commit fa19dfc9f3a072255257f497f393613bae2fe1cd
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Jun 11 14:42:01 2021 +1000

    Add regression test for Savannah #59604.
    
    * tmac/tests/s_IP-indents-using-paragraph-type-size.sh: Add it.
    * tmac/tmac.am (tmac_TEST): Run it.
    
    Test fails at this commit.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59604>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]