[bug #65320] [pdf] doesn't guard control characters when emitting bookmark diversion

[Alejandro Colomar]

Follow-up Comment #1, bug#65320 (group groff):

Tested-by: Alejandro Colomar <alx@kernel.org>

```
alx@debian:~/tmp$ groff -man -Tpdf dot.man >dot.pdf
alx@debian:~/tmp$ open dot.pdf 
alx@debian:~/tmp$ groff --version
GNU groff version 1.23.0.902-1fce7-dirty
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software, distributed under the terms of the GNU General Public
License, version 3, or any later version, at your option.  There is NO
warranty;
not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

programs called:

GNU grops (groff) version 1.23.0.902-1fce7-dirty
GNU troff (groff) version 1.23.0.902-1fce7-dirty
```

With the above, which has your suggested patch manually applied, I see the PDF
bookmark for the subsection, and can't see the warning.

```
alx@debian:~/tmp$ /usr/bin/groff --version
GNU groff version 1.23.0
Copyright (C) 2022 Free Software Foundation, Inc.
GNU groff comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of groff and its subprograms
under the terms of the GNU General Public License.
For more information about these matters, see the file
named COPYING.

called subprograms:

GNU grops (groff) version 1.23.0
GNU troff (groff) version 1.23.0
alx@debian:~/tmp$ /usr/bin/groff -man -Tpdf dot.man >dotold.pdf
troff:dot.man:3: warning: macro 'and' not defined (possibly missing space
after 'an')
alx@debian:~/tmp$ open dotold.pdf 
```

With the above, I see the warning, and the PDF lacks a bookmark for the
subsection.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65320>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/