[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-guile-ncurses] [PATCH 1/2] Add reference count to ITEM structs
From: |
Mike Gran |
Subject: |
Re: [Bug-guile-ncurses] [PATCH 1/2] Add reference count to ITEM structs contained by SCMs |
Date: |
Thu, 26 May 2016 04:32:31 +0000 (UTC) |
>
> Not too excited about this idea, but, it is better that the present
> condition.
>
> I thought a bit about this. The only other reasonable solution I could think
> of
> was to keep a hash table. But that seemed like a lot of effort. It does
> mean
> that one cannot use the userptr for any other purpose, but that kind of
> paradigm
> doesn't fit into the scheme way of doing things anyway.
>
> I wasn't too happy about having to cast from pointer to integer and back
> again.
In the last few commits on master, I implemented something like
your suggested patches with regard to menu items and refcounting.
The work began at
the following commit, and was patched up
the following few commits.
http://git.savannah.gnu.org/cgit/guile-ncurses.git/commit/?id=c3f20ee766c487f8d1d1c47152326e08b56cafb4
I'm in the middle of a long slog to improve the granularity of the test suite,
so I'll try to write some tests for this along the way.
Thanks,
Mike Gran
[Bug-guile-ncurses] [PATCH 2/2] Do not allow menu's internal data to be destroyed, until the menu itself is destroyed., John Darrington, 2016/05/03