bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34526: Updating node.js


From: Daniel Gerber
Subject: bug#34526: Updating node.js
Date: Tue, 19 Feb 2019 17:42:19 +0100


2019-02-18, Jelle Licht:
It seems that llhttp includes a build step for generating C-files using TypeScript, making it a non-starter for proper packaging in Guix. See https://github.com/nodejs/llhttp/issues/14 for more details, but sadly no solution.

What about statically linking llhttp's C "sources" included in node? Building v11.10.0 succeeds with this:

diff --git a/node.gypi b/node.gypi
index c07b5ea704..c08493efbe 100644
--- a/node.gypi
+++ b/node.gypi
@@ -174,6 +174,12 @@
       ],
     } ],
 
+    [ 'node_shared_http_parser=="true"', {
+      'dependencies': [
+        'deps/llhttp/llhttp.gyp:llhttp'
+      ],
+    } ],
+
     [ 'node_shared_cares=="false"', {
       'dependencies': [ 'deps/cares/cares.gyp:cares' ],
     }],

reply via email to

[Prev in Thread] Current Thread [Next in Thread]