Re: [bug-gv] problems with libXaw3D-1.6.1

[Orion Poplawski]

On 02/19/2012 10:19 AM, address@hidden wrote:
> Hello,
>
> After libXaw3d-1.6.1 upgrade, gv-3.7.3 segfaults with:

I've started updating Fedora Rawhide to Xaw3d 1.6.1.  Fedora carries a 
fair number of patches to the library that are still not yet upstream so 
we're not yet complete.

However, I cannot compile gv 3.7.3 against it, I get the following

Scrollbar.c: In function 'Redisplay':
Scrollbar.c:1009:4: error: too few arguments to function 
'swclass->threeD_class.shadowdraw'
Scrollbar.c: In function 'NotifyThumb':
Scrollbar.c:1372:4: warning: dereferencing type-punned pointer will 
break strict-aliasing rules [-Wstrict-aliasing]

1.6.1 defines the shadowdraw interface explicitly:

< 1.5E > 1.6.1
<     void (*shadowdraw)();
---
>     void (*shadowdraw)(Widget, XEvent *, Region, XtRelief, Boolean);

gv calls:

   (*swclass->threeD_class.shadowdraw) (w, event, region, FALSE);

Not sure what the proper last two arguments would be.

The strict-aliasing warning is also a worry, this probably won't work 
with -fno-strict-alias:

    /*
       thumbProc is not pretty, but is necessary for backwards
       compatibility on those architectures for which it work{s,ed};
       the intent is to pass a (truncated) float by value.
    */
   XtCallCallbacks (w, XtNthumbProc, *(XtPointer*)&TOP);

--
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA/CoRA Division                    FAX: 303-415-9702
3380 Mitchell Lane                  address@hidden
Boulder, CO 80301              http://www.cora.nwra.com