[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Signedness bug in eval
From: |
Peter Clifton |
Subject: |
Signedness bug in eval |
Date: |
Thu, 24 May 2007 22:25:56 +0100 |
Please CC me when replying.
Seems like this change broke things...
http://cvs.sv.gnu.org/viewvc/m4/m4/src/eval.c?r1=1.1.1.1.2.7&r2=1.1.1.1.2.8&pathrev=release-1_4_9
Eric, I "think" its yours, but if not, please accept my appologies for
adding you directly to the CC.
Specifically, a colleague who's been helping me debug this verifies that
reverting the change on line 714 fixes the observed bug.
-*v1 = (int32_t) ((uint32_t) *v1 / (uint32_t) v2);
+*v1 = *v1 / v2;
(BTW: I'm on a plain bog standard Intel 32 bit platform).
PS: It seems IMPERITIVE that this fix gets into the distos which ship
1.4.9 ASAP!
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)