Re: [bug-mailutils] [patch] fixed buffer size limits SASL mechanisms

[Alain Magloire]

> 
> 512 bytes is too small for some mechanisms (e.g. GSSAPI), ideally
> auth_gsasl() should check for GSASL_TOO_SMALL_BUFFER return code and
> grow the SASL token buffer, up to some sane limit.  2kb makes for a
> sane limit (for now), so the following is more simplistic.
> 

This is too big for the stack, i.e. I've use mailutils mailbox
library to quickly write some mail utilities on some embedded systems
where the stack size is about 1k(1024).
Altough, I have doubts that a imap server will be use on such systems 8-)
I would still recommand a lower value or malloc/free.

Of course, just a suggestion.

> Thanks.
> 
> Index: auth_gsasl.c
> ===================================================================
> RCS file: /cvsroot/mailutils/mailutils/imap4d/auth_gsasl.c,v
> retrieving revision 1.4
> diff -u -p -u -w -r1.4 auth_gsasl.c
> --- auth_gsasl.c      23 Jan 2003 09:43:07 -0000      1.4
> +++ auth_gsasl.c      1 Feb 2003 09:05:59 -0000
> @@ -66,7 +66,7 @@ auth_gsasl (struct imap4d_command *comma
>            char *auth_type, char *arg, char **username)
>  {
>    char *input = NULL;
> -  char output[512];
> +  char output[2048];
>    size_t output_len;
>    char *s;
>    int rc;
> 
> 
> 
> _______________________________________________
> Bug-mailutils mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-mailutils
>