Re: [bug-mailutils] Debian patches

[Jordi Mallach]

Hi!

On Fri, May 14, 2010 at 12:35:59AM +0300, Sergey Poznyakoff wrote:
> 1. In mail/mail.c, you propose:
> 
> -static char doc[] = N_("GNU mail -- process mail messages.\n"
> +static char doc[] = N_("GNU mail -- process mail messages\n"
> 
> What's wrong with the final point? And why is it wrong only for
> `mail' (other descriptions in this patch do end with it)?

Hrm, This is probably a leftover of a patch that was dropped time ago. At
some point, some of the doc strings had the period, some didn't. I
proposed a patch that removed them from all of the descriptions, but you
judged (rightly) that as full sentences, they should end with a period.
The only explanation for this is that it's a leftover of that patch.

See address@hidden and
commit ee2bb525fbfa5e194b3f572642f146a251115aed.

> 2. In 
> http://patch-tracker.debian.org/patch/series/view/mailutils/1:2.1+dfsg1-6/disable_am_gnu_radius.diff:
> 
> What's the rationale for disabling it? The `FTBFS' in the comment
> doesn't help much in understanding that.  To say nothing about
> `(LP: #nnnnnn)'...

LP stands for "launchpad bug". I guess it would have been better if the
Ubuntu people had actually filled in the actual bug number.

It should be 517366,
https://bugs.launchpad.net/ubuntu/+source/mailutils/+bug/517366

The problem is, GNU radius is not packaged in Debian, so the m4 is not
available. I had forgotten to ask if this m4 can't be added to the
release tarballs, to ease regeneration of configure.

Jordi
-- 
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
address@hidden     address@hidden     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/