[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-myserver] Bug fix in file.cpp + test
From: |
Giuseppe Scrivano |
Subject: |
Re: [bug-myserver] Bug fix in file.cpp + test |
Date: |
Mon, 23 Mar 2009 18:38:27 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) |
Thank you Ivailo!
I can't add your file yet as there is need of copyright assignments, as
soon as we will get them I will add the file to the repository.
I am going to apply the patch instead, openFile must return non-zero if
the file wasn't opened correctly, as you patch is doing.
Giuseppe
ivailo ilionov <address@hidden> writes:
> The bug-fix only adds one line and changes the comment for openFile function.
>
> Well, i'm thinkig that the changed comment is still ambigious, but
> you'll get the idea.
>
> If the function is used without at least MYSERVER_OPEN_READ or
> MYSERVER_OPEN_WRITE and one of the flags:
>
>
> static const u_long MYSERVER_OPEN_TEMPORARY;
> static const u_long MYSERVER_OPEN_ALWAYS;
> static const u_long MYSERVER_OPEN_IFEXISTS;
> static const u_long MYSERVER_OPEN_APPEND;
> static const u_long MYSERVER_CREATE_ALWAYS;
>
> It never tries to open a file - doesn't have a default behaviour.