Re: [Bug-wget] fuzz tests

[Nam Nguyen]

Hi Tim,

Tim Rühsen <address@hidden> writes:
> not sure why, but your email just popped up here though it is dated
> 18.2.2019 9:39 AM.

I sent that e-mail before subscribing to the mailing list and only
noticed that it would be moderated afterward. Now that I am subscribed,
responses should be delivered promptly.

> latest git master should have the tests in fuzz/ being fixed. Please
> give it a try and report back if anything doesn't work on OpenBSD.

I cherry-picked your upstream changes to patch the latest tarball of
wget. Unit tests work and fuzz tests work. (I wonder why the unit tests
did not run previously?) The only change I had to make was
`patch-lib_Makefile_am', because otherwise compilation/linking fails due
to missing symbols in libgnu.a (e.g., from
unicase/empty-prefix-context.c). What do you think?

patch-lib_Makefile_am
--8<---------------cut here---------------start------------->8---
$OpenBSD$

add unknown symbols to libgnu

Index: lib/Makefile.am
--- lib/Makefile.am.orig
+++ lib/Makefile.am
@@ -3114,17 +3114,13 @@ EXTRA_DIST += unicase/cased.h unicase/caseprop.h unict
 
 ## begin gnulib module unicase/empty-prefix-context
 
-if LIBUNISTRING_COMPILE_UNICASE_EMPTY_PREFIX_CONTEXT
 libgnu_a_SOURCES += unicase/empty-prefix-context.c
-endif
 
 ## end   gnulib module unicase/empty-prefix-context
 
 ## begin gnulib module unicase/empty-suffix-context
 
-if LIBUNISTRING_COMPILE_UNICASE_EMPTY_SUFFIX_CONTEXT
 libgnu_a_SOURCES += unicase/empty-suffix-context.c
-endif
 
 ## end   gnulib module unicase/empty-suffix-context
 
@@ -3447,9 +3443,7 @@ EXTRA_DIST += unistr.in.h
 
 ## begin gnulib module unistr/u8-cpy
 
-if LIBUNISTRING_COMPILE_UNISTR_U8_CPY
 libgnu_a_SOURCES += unistr/u8-cpy.c
-endif
 
 EXTRA_DIST += unistr/u-cpy.h
 
@@ -3457,9 +3451,7 @@ EXTRA_DIST += unistr/u-cpy.h
 
 ## begin gnulib module unistr/u8-mbtouc-unsafe
 
-if LIBUNISTRING_COMPILE_UNISTR_U8_MBTOUC_UNSAFE
 libgnu_a_SOURCES += unistr/u8-mbtouc-unsafe.c unistr/u8-mbtouc-unsafe-aux.c
-endif
 
 ## end   gnulib module unistr/u8-mbtouc-unsafe
 
@@ -3473,9 +3465,7 @@ endif
 
 ## begin gnulib module unistr/u8-uctomb
 
-if LIBUNISTRING_COMPILE_UNISTR_U8_UCTOMB
 libgnu_a_SOURCES += unistr/u8-uctomb.c unistr/u8-uctomb-aux.c
-endif
 
 ## end   gnulib module unistr/u8-uctomb
--8<---------------cut here---------------end--------------->8---

> ASAN / UBSAN builds (or valgrind test runs)
> The test data comes mainly from OSS-Fuzz and covers all kinds of code
> paths (though we are far away from 100%).

This sounds like a really interesting concept to me. I also need to
learn more about autoconf and Makefiles. Thank you for the clear
explanations.

Attaching test logs:
test.log: output from ports tree `make test'
wget_css_fuzzer.log: log file found in fuzz/

Best Regards,
Nam

test.log
Description: test.log

wget_css_fuzzer.log
Description: wget_css_fuzzer.log