mailutils/mail alias.c copy.c decode.c delete.c...

[Alain Magloire]

CVSROOT:        /home/cvs
Module name:    mailutils
Changes by:     Alain Magloire <address@hidden> 01/09/15 16:50:43

Modified files:
        mail           : alias.c copy.c decode.c delete.c eq.c exit.c 
                         folders.c followup.c from.c headers.c if.c 
                         inc.c list.c mail.c mail.h mailline.c msgset.y 
                         pipe.c print.c quit.c send.c shell.c summary.c 
                         table.c tag.c util.c var.c version.c write.c 
                         z.c 

Log message:
        The exercise is to crank up the warnings from gcc and cleanup
        the code based on the hints generated by the compiler.  The usual
        errors:
        - signed vs unsigned, signedness or unsignedness problems.
        - printf() wrong formats
        - wrong prototypes declarations
        - and different buglets
        - "const char *" vs "char *"
        - unused variables
        - unused arguments.  Tell the compiler by typecasting to void
        (void)var.
        - Some variable when shadowed, meaning in another block variable
        of the same name where reused.
        - atoi() is not an ANSI C function, we should use strtol().
        
        Changes to comply to GNU coding standards, and nuke trailing spaces.
        
        * mail/alias.c (alia_lookup): No prototypes and scope static.
        (hash_num, max_rehash, aliases): Scope static and unsigned.
        (hash): unsigned.
        (alias_rehash): i unsigned.
        (alias_lookup_or_install): slot variable unused.
        (alias_destroy): unsigned.
        * mail/copy.c (mail_copy0): fprintf wrong format.
        * mail/decode.c: dislay_message change prototype.
        (mail_decode): Cast when calling util_msgset_iterate().
        (display_message): Prototype change.
        (display_headers): unsigned issues.
        * mail/delete.c: Buglet was caling mail_delete0() instead of
        mail_delete.
        * mail/eq.c: Unused arguments.
        * mail/exit.c: Unused arguments.
        * mail/folders.c: Unused arguments.
        * mail/followup.c: Unused variables.
        * mail/from.c (mail_from): variable buffer was shadowing use variable
        name instead. snprintf() formatting issues.
        * mail/headers.c: Unsigned issues.
        * mail/if.c: Unused arguments.
        * mail/inc.c: Unused arguments.
        * mail/list.c: Use const char *.
        * mail/mail.c: options[], argp[] initialised all elements.
        (mail_cmdline): Unused arguments.
        (main): Unsigned issues.
        (mail_warranty): Unused arguments.
        * mail/mail.h: function_t with complete prototype this necessary
        to let the compiler do proper checks.
        struct mail_command_entry rearrange the fields and a new field
        int (*escfunc) __P ((int, char **, struct send_environ *));
        Indentation rearrangements.
        * mail/mailline.c (ml_getc): Scope is static now.
        typecast for const char *.
        (ml_reread): Typecast.
        * mail/msgset.y: Declare yyerror() and yylex().
        (msgset_select): Change of prototpe to let the compiler do checks.
        (selec_sender): Unsused arguments.
        * mail/pipe.c: Rename variable pipe to tube.
        * mail/print.c: Unsigness and some shadow variables.
        * mail/quit.c: Shadow variables.
        * mail/send.c: Typecast when necessary. Use the second (escfunc)
        field now. Some shadow variables.
        * mail/shell.c: Unsigned.
        * mail/table.c: Readjust the table to correspond to the signature
        change in mail.h.
        * mail/tag.c: Prototype change.
        * mail/util.c (util_msglist_esccmd): New function.
        (util_find_entry): Prototype change.  And check return value
        of getenv().
        (util_screen_lines): Change atoi() to strtoul().
        (util_screen_columns): Change atoi() to strtoul().
        (util_find_env): Signedness.
        (util_fullpath): Prototype changed(const).
        (util_slist_to_string):Protorype changed (const).
        (util_strcat) :Protorype changed (const).
        (util_tempfile): const.
        * mail/var.c: Unsignedness, Unused arguments.
        (var_quote):  Use new function util_msglist_esccmd().
        * mail/version.c: Unused arguments.
        * mail/write.c: printf formats.
        * mail/z.c: Signedness.

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/alias.c.diff?cvsroot=OldCVS&tr1=1.8&tr2=1.9&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/copy.c.diff?cvsroot=OldCVS&tr1=1.10&tr2=1.11&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/decode.c.diff?cvsroot=OldCVS&tr1=1.5&tr2=1.6&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/delete.c.diff?cvsroot=OldCVS&tr1=1.10&tr2=1.11&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/eq.c.diff?cvsroot=OldCVS&tr1=1.3&tr2=1.4&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/exit.c.diff?cvsroot=OldCVS&tr1=1.3&tr2=1.4&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/folders.c.diff?cvsroot=OldCVS&tr1=1.5&tr2=1.6&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/followup.c.diff?cvsroot=OldCVS&tr1=1.8&tr2=1.9&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/from.c.diff?cvsroot=OldCVS&tr1=1.12&tr2=1.13&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/headers.c.diff?cvsroot=OldCVS&tr1=1.10&tr2=1.11&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/if.c.diff?cvsroot=OldCVS&tr1=1.5&tr2=1.6&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/inc.c.diff?cvsroot=OldCVS&tr1=1.1&tr2=1.2&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/list.c.diff?cvsroot=OldCVS&tr1=1.6&tr2=1.7&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/mail.c.diff?cvsroot=OldCVS&tr1=1.45&tr2=1.46&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/mail.h.diff?cvsroot=OldCVS&tr1=1.32&tr2=1.33&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/mailline.c.diff?cvsroot=OldCVS&tr1=1.7&tr2=1.8&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/msgset.y.diff?cvsroot=OldCVS&tr1=1.7&tr2=1.8&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/pipe.c.diff?cvsroot=OldCVS&tr1=1.9&tr2=1.10&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/print.c.diff?cvsroot=OldCVS&tr1=1.15&tr2=1.16&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/quit.c.diff?cvsroot=OldCVS&tr1=1.9&tr2=1.10&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/send.c.diff?cvsroot=OldCVS&tr1=1.17&tr2=1.18&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/shell.c.diff?cvsroot=OldCVS&tr1=1.9&tr2=1.10&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/summary.c.diff?cvsroot=OldCVS&tr1=1.2&tr2=1.3&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/table.c.diff?cvsroot=OldCVS&tr1=1.17&tr2=1.18&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/tag.c.diff?cvsroot=OldCVS&tr1=1.2&tr2=1.3&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/util.c.diff?cvsroot=OldCVS&tr1=1.33&tr2=1.34&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/var.c.diff?cvsroot=OldCVS&tr1=1.4&tr2=1.5&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/version.c.diff?cvsroot=OldCVS&tr1=1.2&tr2=1.3&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/write.c.diff?cvsroot=OldCVS&tr1=1.11&tr2=1.12&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/mailutils/mail/z.c.diff?cvsroot=OldCVS&tr1=1.9&tr2=1.10&r1=text&r2=text